Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include portalId and userId in the onReady payload #193

Merged
merged 11 commits into from
Apr 22, 2024
Merged

Include portalId and userId in the onReady payload #193

merged 11 commits into from
Apr 22, 2024

Conversation

alonso-cadenas
Copy link
Collaborator

@alonso-cadenas alonso-cadenas commented Apr 22, 2024 •
edited
Loading

Description

Jira Ticket: CALL-6290

  • Adds the portalId and userId to the onReady payload.
  • Adds the portalId and userId to the demo-minimal-js.
  • I attempted to add the portalId and userId to the demo-react-ts but there's no usages for it right now.

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix?
Minor: New Feature? ✅
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible? ✅
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work? ✅
Expect Dependencies to Fail? ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-193/
on branch gh-pages at 2024-04-22 23:48 UTC

@alonso-cadenas alonso-cadenas changed the title Call 6290 Include portalId in the onReady payload Apr 22, 2024
@alonso-cadenas alonso-cadenas marked this pull request as ready for review April 22, 2024 19:56
@alonso-cadenas alonso-cadenas requested a review from a team as a code owner April 22, 2024 19:56
@alonso-cadenas alonso-cadenas changed the title Include portalId in the onReady payload Include portalId and userId in the onReady payload Apr 22, 2024
@alonso-cadenas alonso-cadenas merged commit f7ae0cc into master Apr 22, 2024
1 check passed
@alonso-cadenas alonso-cadenas deleted the CALL-6290 branch April 22, 2024 23:49
@esme esme mentioned this pull request Apr 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esme esme esme approved these changes

@hemang-thakkar hemang-thakkar Awaiting requested review from hemang-thakkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alonso-cadenas @esme